omarandClaude Opus 5
63e6b709f8
The short-circuit left the chain's exit tag untested, because the exit is itself a hop and every hop behind the break was rewritten that way. A stand run caught it — the test lives in a file that does not compile on the dev host, so nothing local could have. That is not neutral silence. selectExcluding ranks untested ABOVE dead and says so in its own comment: with no fresh-alive member, an untested one is a better bet than a known-dead one. Leaving a provably broken path untested is therefore a positive preference for it over a path we merely know is dead. The two readings answer different questions and now differ on purpose. Is this hop's own node alive — unknown behind a break, so the card keeps untested and blocked_by. Can this chain carry traffic — known, no, because the hop in front of it was probed and did not answer. The board carries that second answer, which is the one selection, the freshness gate and the manual test all read. The exit verdict is derived, not dialled: it records the consequence of a probe that did happen one hop earlier, and it is re-derived every pass, so the moment the blocker answers the walk reaches the exit again and the next verdict there is a real measurement. Also keeps a routed group warm. Its checker used to stop on the idle timeout and nothing filled in behind it, so a rule that fires rarely would show untested while being in force and pay a cold probe on the first real request. The gate that adds this work answers false when it does not know — the mirror of the one that withholds work, so plain sing-box keeps the lifecycle it always had. And the tls-spoof suite now skips without tcpdump instead of failing sixteen times: a missing tool is not measured, not broken. The same distinction this commit is about. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
62 lines
3.2 KiB
Go
62 lines
3.2 KiB
Go
package urltest
|
|
|
|
// lx: health board §5.C — the reachability half of "should this be probed".
|
|
//
|
|
// # Two different reasons not to probe, and why they cannot be one flag
|
|
//
|
|
// A group's OWN probing schedule is stood down for two unrelated reasons, and
|
|
// conflating them breaks one of the two:
|
|
//
|
|
// - NOT USED — no enabled routing rule reaches this group, so probing it
|
|
// measures a path nothing travels. That is a property of the CONFIG, it is
|
|
// decided once when the config is generated, and it travels in the config
|
|
// itself (option.URLTestOutboundOptions.SelfCheck). It cannot change while
|
|
// the box runs, because the rules cannot change while the box runs.
|
|
//
|
|
// - NOT REACHABLE RIGHT NOW — the group is a hop of a chain and a hop in
|
|
// FRONT of it is currently dead. Every member of this group dials through
|
|
// that hop, so every probe would fail inside it: the measurement would be
|
|
// about the broken hop, and would be recorded against this one. That is a
|
|
// property of the WORLD, it changes minute by minute, and it must be
|
|
// re-asked every time rather than baked into the config — a hop that comes
|
|
// back must resume probing on its own, with no reapply and nobody pressing
|
|
// anything.
|
|
//
|
|
// ProbeGate is the second one. It is deliberately a QUESTION asked at the
|
|
// moment of probing and never a stored answer: there is no flag to set, so
|
|
// there is no flag to forget to clear.
|
|
//
|
|
// The gate governs the group's own SCHEDULE only — the warm-up sweep and the
|
|
// ticker. An explicit check (a human, an API call) is a deliberate request and
|
|
// is never refused, exactly as with SelfCheck.
|
|
type ProbeGate interface {
|
|
// ProbeAllowed reports whether the outbound tagged tag may run its own
|
|
// scheduled probe right now.
|
|
//
|
|
// Implementations MUST answer true when they do not know: a gate that
|
|
// refuses on missing information would silence probing precisely when the
|
|
// system has the least idea what is going on, and nothing would ever
|
|
// measure its way out of that. A nil ProbeGate means "no gate" and every
|
|
// probe proceeds.
|
|
ProbeAllowed(tag string) bool
|
|
|
|
// ProbeWhenIdle reports whether the outbound tagged tag must keep measuring
|
|
// even when no traffic is passing through it.
|
|
//
|
|
// A urltest group normally probes only while it is in use: Touch arms the
|
|
// ticker on a dial, and the idle timeout stops it again. That is right for a
|
|
// group whose readings matter only while somebody is dialling it, and wrong
|
|
// for one the routing config REACHES: a rule that matches rarely — a narrow
|
|
// domain list, say — is in force the whole time, so the health of its target
|
|
// is a live question the whole time. Letting it go quiet means the panel
|
|
// reports "untested" about a rule that is armed, and the first real request
|
|
// pays a cold probe instead of picking an already-known-good member.
|
|
//
|
|
// Unlike ProbeAllowed, the safe answer here is FALSE when nothing is known.
|
|
// This one ADDS work, and a gate that claimed it on missing information would
|
|
// keep every group in the process probing forever — not a default anybody
|
|
// asked for. Absent gate, unknown tag, nothing configured yet: false, and the
|
|
// idle timeout behaves exactly as it always has.
|
|
ProbeWhenIdle(tag string) bool
|
|
}
|